Handle case numbers without number and year #1420
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmwangemi
force-pushed
the
judgment-titles
branch
4 times, most recently
from
6af434f
to
9ed3477
Compare
peachjam/models/judgment.py
Outdated
| parts = [] | ||
|
|
||
| # Appeal 5 of 2018 (matter_type number year) | ||
| if self.matter_type and self.number and self.year: |
There was a problem hiding this comment.
You're adding partially built components, and having to handle all the permutations. I suggest simply adding them one-by-one, which will handle things better:
if self.matter_type:
parts.append(self.matter_type)
if self.number:
parts.append(self.number)
if self.year:
parts.append(f'of {self.year}' if parts else self.year)
return ' '.join(parts)
nickmwangemi
force-pushed
the
judgment-titles
branch
from
9ed3477
to
8b46394
Compare
longhotsummer
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appeal 5 of 2018
Appeal of 2018
Appeal 5
5 of 2018
2018
5